Conversation
Minkyu0424
reviewed
Feb 1, 2025
| <slot name="listBar" /> | ||
|
|
||
| <div class="overflow-y-auto"> | ||
| <div class="grow overflow-y-auto"> |
Contributor
Author
There was a problem hiding this comment.
아뇨 grow는 flex-grow:1을 부여하는 클래스로 상위 요소가 flex인 경우 다른 요소들이 차지하는 공간을 제외하고 나머지의 공간을 차지하게 하는 속성입니다.
grow를 하여 NoContent 컴포넌트를 위한 공간을 확보해주기 위한 클래스입니다!
Minkyu0424
reviewed
Feb 1, 2025
Minkyu0424
reviewed
Feb 1, 2025
| @@ -43,7 +46,7 @@ const fetchRequestList = async () => { | |||
| headers: { | |||
Contributor
Author
There was a problem hiding this comment.
넵! 일단 현재는 원시적으로 직접 토큰값을 저장하여 환경 변수로 사용하고 있는데 이후 로그인 구현 후 그에 맞게 수정하도록 하겠습니다!
Minkyu0424
reviewed
Feb 1, 2025
| queryFn: fetchRequestList | ||
| }) | ||
|
|
||
| watch( |
Contributor
There was a problem hiding this comment.
이게 useEffect랑 depenency처럼 동작하는거 맞을까요?
Contributor
Author
There was a problem hiding this comment.
네 맞습니다!
watch() 안에 watch가 주시할 변수를 지정하고, 안에 콜백 함수를 통해 해당 변수가 변화 했을 때의 행동을 정의하였습니다.
또한 once 옵션을 통해 처음에 data를 받아왔을 때의 totalPage를 한 번 설정하고, 이후 재설정을 막아 ListPagination 컴포넌트의 반복적인 리렌더링을 막고자 하였습니다!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#️⃣연관된 티켓 넘버
📝작업 내용
🏞️스크린샷 (선택)
💬리뷰 요구사항(선택)